fix(codecatalyst): cache results of verifySession (#3113)

## Problem
verifySession is called every time a new client is created

## Solution
Cache verifySession based off the access token

### Testing
The way the CodeCatalyst client is written makes it difficult to test in a sustainable way. Something similar to #2917 needs to be done to reduce the amount of custom logic in each service client.

Author: JadenSimon

src/shared/clients/codecatalystClient.ts

@@ -180,7 +180,19 @@ class CodeCatalystClientInternal {
     private userDetails?: UserDetails
     private readonly log: logger.Logger
 
+    /**
+     * Maps bearer tokens to CAWS identities via `verifySession`
+     *
+     * It's assumed that an identity will never change over the lifetime of a token
+     */
     private static identityCache = new Map<string, string>()
+
+    /**
+     * Maps CAWS identities to user details via  `getUserDetails`
+     *
+     * User details _might_ change at some point, however, this is an uncommon occurence.
+     * Cached user details are cleared when the access token is refreshed.
+     */
     private static userDetailsCache = new Map<UserDetails['userId'], UserDetails>()
 
     public constructor(private readonly connection: SsoConnection, private readonly sdkClient: CodeCatalyst) {
@@ -320,7 +332,11 @@ class CodeCatalystClientInternal {
         const resp = await this.call(this.sdkClient.verifySession(), false)
         assertHasProps(resp, 'identity')
 
-        setTimeout(() => CodeCatalystClientInternal.identityCache.delete(accessToken), expiresAt.getTime() - Date.now())
+        CodeCatalystClientInternal.identityCache.set(accessToken, resp.identity)
+        setTimeout(() => {
+            CodeCatalystClientInternal.identityCache.delete(accessToken)
+            CodeCatalystClientInternal.userDetailsCache.delete(resp.identity)
+        }, expiresAt.getTime() - Date.now())
 
         return resp.identity
     }