Feature - Update aws-toolkit-commons package #4159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update AmazonQ Code Transform telemetry definitions for new package update
damntrecky
commented
Dec 11, 2023
| @@ -93,7 +93,7 @@ export async function validateProjectSelection(project: vscode.QuickPickItem) { | |||
| vscode.window.showErrorMessage(CodeWhispererConstants.noSupportedJavaProjectsFoundMessage, { modal: true }) | |||
| telemetry.codeTransform_isDoubleClickedToTriggerInvalidProject.emit({ | |||
| codeTransformSessionId: codeTransformTelemetryState.getSessionId(), | |||
| codeTransformPreValidationError: 'No Java project found' as CodeTransformPreValidationError, | |||
There was a problem hiding this comment.
Typecast with as is unnecessary.
damntrecky
commented
Dec 11, 2023
| @@ -125,8 +125,7 @@ export async function validateProjectSelection(project: vscode.QuickPickItem) { | |||
| vscode.window.showErrorMessage(CodeWhispererConstants.noSupportedJavaProjectsFoundMessage, { modal: true }) | |||
| telemetry.codeTransform_isDoubleClickedToTriggerInvalidProject.emit({ | |||
| codeTransformSessionId: codeTransformTelemetryState.getSessionId(), | |||
| codeTransformPreValidationError: | |||
| 'Project selected is not Java 8 or Java 11' as CodeTransformPreValidationError, | |||
| codeTransformPreValidationError: 'UnsupportedJavaVersion', | |||
There was a problem hiding this comment.
New values DO NOT have spaces.
justinmk3
approved these changes
Dec 11, 2023
|
https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#changelog
Is that the case here? |
added 3 commits
December 11, 2023 15:28
- update AmazonQ Code Transform telemetry definitions for new package update
…thub.com:damntrecky/aws-toolkit-vscode into nardeck/amazonq-code-transform-telemetry-updates
damntrecky
commented
Dec 11, 2023
| @@ -0,0 +1,4 @@ | |||
| { | |||
There was a problem hiding this comment.
Should delete this since its non user facing?
There was a problem hiding this comment.
yeah I'd say so. Also would suggest using "telemetry" as the commit-message prefix (aka topic)
justinmk3
reviewed
Dec 12, 2023
| telemetry.codeTransform_isDoubleClickedToTriggerInvalidProject.emit({ | ||
| codeTransformSessionId: codeTransformTelemetryState.getSessionId(), | ||
| codeTransformPreValidationError: 'Only Maven projects supported' as CodeTransformPreValidationError, | ||
| codeTransformPreValidationError: 'NoPom', |
There was a problem hiding this comment.
could save some repeated code (though I see that reason was omitted below?)
Suggested change
| codeTransformPreValidationError: 'NoPom', | |
| codeTransformPreValidationError: buildType === 'Gradle' ? NonMavenProject : 'NoPom', |
leigaol
approved these changes
Dec 12, 2023
|
/retryBuilds |
damntrecky
deleted the
nardeck/amazonq-code-transform-telemetry-updates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We update the AWS Toolkit Common package and need to update the VSCode package per this PR -> aws/aws-toolkit-common#648
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.