telemetry(amazonq chat): numberOfCodeBlocks #4761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogusata
suggested changes
Apr 22, 2024
Contributor
dogusata
left a comment
dogusata
left a comment
There was a problem hiding this comment.
Please replace the code block calculation method with ui endstream method return.
packages/core/src/codewhispererChat/controllers/chat/messenger/messenger.ts
Outdated
Show resolved
Hide resolved
6 tasks
dogusata
approved these changes
Apr 22, 2024
mitroviv
reviewed
Apr 22, 2024
Comment on lines
101
to
102
| // Count the number of <pre> tags in the HTML to find the total number of code blocks | ||
| const totalNumberOfCodeBlocks = (html.match(/<pre>/g) || []).length |
There was a problem hiding this comment.
This is not specific enough - it could match unrelated <pre> tags.
Contributor
There was a problem hiding this comment.
My suggestion would be jsdom and the method querySelectorAll with a query of pre > code to find all code blocks
mitroviv
reviewed
Apr 22, 2024
packages/core/src/codewhispererChat/controllers/chat/messenger/messenger.ts
Show resolved
Hide resolved
dogusata
approved these changes
Apr 23, 2024
dogusata
reviewed
Apr 23, 2024
packages/core/src/codewhispererChat/controllers/chat/messenger/messenger.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
recordAddMessageis missing the required parametercwsprChatResponseCodeSnippetCountfor AB testing.Solution
TODO:
This is a temporary solution (until backend response contains the number of code blocks with the last chunk), revert this change once backend is ready and use data from the backend.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.