Skip to content

telemetry(dev): add tracking for empty path file scenario #5625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 9, 2024
+26 −3
Merged

telemetry(dev): add tracking for empty path file scenario #5625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
632780b
fix(amazonqFeatureDev): include telemetry for empty scenario
tverney Sep 18, 2024
0f5a10a
chore(amazonqFeatureDev): add changelog
tverney Sep 18, 2024
907bb5f
fix(amazonqFeatureDev): update telemetry based on comments
tverney Sep 18, 2024
c1aa580
fix(amazonqFeatureDev): update naming accordingly
tverney Sep 25, 2024
db17fda
fix(amazonqFeatureDev): updated emit
tverney Sep 25, 2024
9f2ccaa
Update sessionState.ts
tverney Sep 25, 2024
2565697
Update vscodeTelemetry.json
tverney Sep 25, 2024
895351c
Update vscodeTelemetry.json
tverney Sep 25, 2024
3bbd8ab
fix(dev): remove trackScenario since its on common
tverney Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/amazonq/.changes/next-release/Bug Fix-0d324321-bddd-4f93-80c4-80978930f157.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "Amazon Q /dev: include telemetry for workspace usage when generating new files"
}
25 changes: 22 additions & 3 deletions packages/core/src/amazonqFeatureDev/session/sessionState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ function registerNewFiles(
fs: VirtualFileSystem,
newFileContents: NewFileZipContents[],
uploadId: string,
workspaceFolders: CurrentWsFolders
workspaceFolders: CurrentWsFolders,
conversationId: string
): NewFileInfo[] {
const result: NewFileInfo[] = []
const workspaceFolderPrefixes = getWorkspaceFoldersByPrefixes(workspaceFolders)
Expand All @@ -81,6 +82,12 @@ function registerNewFiles(
Object.values(workspaceFolderPrefixes).find((val) => val.index === 0)?.name ?? ''
]
if (folder === undefined) {
telemetry.toolkit_trackScenario.emit({
count: 1,
amazonqConversationId: conversationId,
credentialStartUrl: AuthUtil.instance.startUrl,
scenario: 'wsOrphanedDocuments',
})
getLogger().error(`No workspace folder found for file: ${zipFilePath} and prefix: ${prefix}`)
continue
}
Expand Down Expand Up @@ -174,7 +181,13 @@ abstract class CodeGenBase {
case CodeGenerationStatus.COMPLETE: {
const { newFileContents, deletedFiles, references } =
await this.config.proxyClient.exportResultArchive(this.conversationId)
const newFileInfo = registerNewFiles(fs, newFileContents, this.uploadId, workspaceFolders)
const newFileInfo = registerNewFiles(
fs,
newFileContents,
this.uploadId,
workspaceFolders,
this.conversationId
)
telemetry.setNumberOfFilesGenerated(newFileInfo.length)

return {
Expand Down Expand Up @@ -378,7 +391,13 @@ export class MockCodeGenState implements SessionState {
zipFilePath: f.zipFilePath,
fileContent: f.fileContent,
}))
this.filePaths = registerNewFiles(action.fs, newFileContents, this.uploadId, this.config.workspaceFolders)
this.filePaths = registerNewFiles(
action.fs,
newFileContents,
this.uploadId,
this.config.workspaceFolders,
this.conversationId
)
this.deletedFiles = [
{
zipFilePath: 'src/this-file-should-be-deleted.ts',
Expand Down
Loading