feat(ec2): provide link for customer to view system logs #5633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
Hweinstock
changed the title
Hweinstock
changed the title
justinmk3
reviewed
Oct 16, 2024
justinmk3
reviewed
Oct 16, 2024
justinmk3
reviewed
Oct 16, 2024
Contributor
|
LGTM after CI passes :) cc @keeganirby for visibility. Related: this upcoming feature-branch enhances |
justinmk3
reviewed
Oct 16, 2024
justinmk3
approved these changes
Oct 16, 2024
Co-authored-by: Justin M. Keyes <[email protected]>
tverney
pushed a commit
to tverney/aws-toolkit-vscode
that referenced
this pull request
Oct 21, 2024
## Problem Limited ability to diagnose problems with EC2 instances provided in the toolkit. ## Solution Add a right click option to provide system log of Ec2 instance in read-only file view. ### Implementation Details - Log view does NOT live update. This would require refactoring the CWL significantly. Better to get the feature out and see if this is something customers want/need. - To reduce code duplication two new utility components were added `decodeBase64` in`core/src/shared/utilities/textUtilities.ts` and `UriSchema` in `core/src/shared/utilities/uriUtils.ts`. - `decodeBase64` is a helper function to wrap the use of `Buffer.from(X, "base64").toString()` throughout the toolkit. - `UriSchema` provides a general framework for translating between an object and an URI, and vice versa. It allows us to avoid writing the `isValid` method in all cases. With more work this could likely be more general, but is only used twice so unclear if it is worth pursuing. - These changes involved changing some function calls, especially in the CWL code, but does not impact functionality. ### Pictures <img width="1231" alt="image" src="https://github.com/user-attachments/assets/0991c51e-6e27-4102-a85f-08246a7faab0"> <img width="1508" alt="image" src="https://github.com/user-attachments/assets/558d831f-7a7c-475b-9400-719ce8fd99d7"> --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Justin M. Keyes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Limited ability to diagnose problems with EC2 instances provided in the toolkit.
Solution
Add a right click option to provide system log of Ec2 instance in read-only file view.
Implementation Details
decodeBase64incore/src/shared/utilities/textUtilities.tsandUriSchemaincore/src/shared/utilities/uriUtils.ts.decodeBase64is a helper function to wrap the use ofBuffer.from(X, "base64").toString()throughout the toolkit.UriSchemaprovides a general framework for translating between an object and an URI, and vice versa. It allows us to avoid writing theisValidmethod in all cases. With more work this could likely be more general, but is only used twice so unclear if it is worth pursuing.Pictures
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.