Skip to content

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Sep 21, 2024

Problem

Remove ALL usage of userGroupSettings as we're pivoting to featureConfigProvider.ts

Solution


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested review from a team as code owners September 21, 2024 00:43
@github-actions
Copy link

This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@Will-ShaoHua Will-ShaoHua marked this pull request as draft September 21, 2024 00:45
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review September 21, 2024 01:08
@Will-ShaoHua Will-ShaoHua marked this pull request as draft September 25, 2024 03:03
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review October 6, 2024 05:34
Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready to merge? Did a Q/CW team member review it?

May need to rebase to get CI passing.

@justinmk3 justinmk3 changed the title cleanup(codewhisperer): remove usage of UserGroupSettings refactor(codewhisperer): remove usage of UserGroupSettings Oct 7, 2024
@Will-ShaoHua
Copy link
Contributor Author

Will-ShaoHua commented Oct 7, 2024

Is this ready to merge? Did a Q/CW team member review it?

yea let me rebase it and request Q team to review it.

@Will-ShaoHua
Copy link
Contributor Author

  2631 passing (55s)
  12 pending
  1 failing
  1) startSecurityScanPerformanceTest
       Should calculate cpu and memory usage for file scans performance tests
         "after all" hook for "Should calculate cpu and memory usage for file scans - test run 10":

      AssertionError [ERR_ASSERTION]: Expected total user CPU usage for Should calculate cpu and memory usage for file scans to be less than 50. Actual user CPU usage was 67.04591225728144
      + expected - actual

      -false
      +true

@nkomonen-amazon nkomonen-amazon merged commit db4bf31 into aws:master Oct 9, 2024
22 of 24 checks passed
@Will-ShaoHua Will-ShaoHua deleted the cwspr-usergroup branch October 9, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants