feat(filesystem): add stub for chmod to filesystem wrapper #5647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hweinstock
changed the title
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
Contributor
Author
|
/retryBuilds |
justinmk3
reviewed
Sep 24, 2024
|
|
||
| it('sets permission of the file to read/write owner', async function () { | ||
| if (!globals.isWeb && os.platform() !== 'win32') { | ||
| const result = await stat(keyPair.getPrivateKeyPath()) |
Contributor
There was a problem hiding this comment.
Oh I guess we will need fs.stat(), later...
justinmk3
approved these changes
Sep 24, 2024
Contributor
justinmk3
left a comment
justinmk3
left a comment
There was a problem hiding this comment.
Thanks! Are there any existing usages we can replace too?
justinmk3
reviewed
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changing the permissions of a file is currently not supported by the file system wrapper.
Solution
Implement a stub chmod that does nothing on web, and uses
fsto modify permissions in non-web environments.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.