config(amazonq): enable more languages in generateCompletion requests #5663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lua, r, swift, vue
|
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
Will-ShaoHua
changed the title
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
andrewyuq
approved these changes
Oct 7, 2024
Will-ShaoHua
changed the title
Contributor
Author
|
will attach functional test screen recording |
Will-ShaoHua
changed the title
Will-ShaoHua
requested review from
hayemaxi,
jpinkney-aws,
justinmk3 and
nkomonen-amazon
nkomonen-amazon
approved these changes
Oct 9, 2024
Will-ShaoHua
changed the title
Contributor
Author
|
2636 passing (5m)
assert_1.default.ok(!refreshedConnItem.description?.match(/expired/i)) |
justinmk3
changed the title
Will-ShaoHua
added a commit
to Will-ShaoHua/aws-toolkit-vscode
that referenced
this pull request
Oct 24, 2024
jpinkney-aws
pushed a commit
that referenced
this pull request
Oct 25, 2024
… (#5854) ## Problem patch #5663 Due to this line of code https://github.com/aws/aws-toolkit-vscode/blob/master/packages/core/src/codewhisperer/util/runtimeLanguageContext.ts#L156-L173 when users make inline completion call with new languages, logs will show `2024-10-24 08:52:55.501 [error] codewhisperer: unknown runtime language dart`, however it doesn't have functional impact because it will fallback to original language string (which is the reason why it doesn't fail test cases) and it's only affecting logs. test has been added https://github.com/aws/aws-toolkit-vscode/blob/master/packages/amazonq/test/unit/codewhisperer/util/runtimeLanguageContext.test.ts#L184-L222 ## Solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Per product team's request, unblock requests of the following language to the service which will be ready soon. (thus not calling it out as a "feat" as it's not supported yet)
Solution
Functional test
vscode-swift.mov
vscode-lua.mov
vscode-dart.mov
vscode-r.mov
vscode-systemverilog.mov
vscode-powershell.mov
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.