config(amazonq): patch language configuration not added correctly #5663 #5854
Conversation
|
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
|
will figure out a better to deal with all the language stuff happening in codewhisperer codebase. It's tech debt and error prone |
|
Typo in description |
Will-ShaoHua
changed the title
| 'kotlin', | ||
| 'php', | ||
| 'python', | ||
| 'powershell', |
There was a problem hiding this comment.
verified, equal to jb
const val ID = "powershell"
| 'php', | ||
| 'python', | ||
| 'powershell', | ||
| 'r', |
There was a problem hiding this comment.
verified, equal to jb
const val ID = "r"
| 'python', | ||
| 'powershell', | ||
| 'r', | ||
| 'dart', |
There was a problem hiding this comment.
verified, equal to jb
const val ID = "dart"
| 'scala', | ||
| 'shell', | ||
| 'sql', | ||
| 'swift', |
There was a problem hiding this comment.
const val ID = "swift"
| 'shell', | ||
| 'sql', | ||
| 'swift', | ||
| 'lua', |
There was a problem hiding this comment.
verified, equal to jb
const val ID = "lua"
| 'sql', | ||
| 'swift', | ||
| 'lua', | ||
| 'vue', |
There was a problem hiding this comment.
verified, equal to jb
const val ID = "vue"
| if (inputCwsprLanguageId === 'systemVerilog') { | ||
| console.log() | ||
| } |
5 participants
Problem
patch #5663
Due to this line of code https://github.com/aws/aws-toolkit-vscode/blob/master/packages/core/src/codewhisperer/util/runtimeLanguageContext.ts#L156-L173
when users make inline completion call with new languages, logs will show
2024-10-24 08:52:55.501 [error] codewhisperer: unknown runtime language dart, however it doesn't have functional impact because it will fallback to original language string (which is the reason why it doesn't fail test cases) and it's only affecting logs.test has been added https://github.com/aws/aws-toolkit-vscode/blob/master/packages/amazonq/test/unit/codewhisperer/util/runtimeLanguageContext.test.ts#L184-L222
Solution
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.