Skip to content

config(amazonq): patch language configuration not added correctly #5663 #5854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2024
Merged

config(amazonq): patch language configuration not added correctly #5663 #5854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57ce807
patch language configiration not added correctly #5663
Will-ShaoHua Oct 24, 2024
2203d82
add powershell
Will-ShaoHua Oct 24, 2024
e38b023
remove dev console.log
Will-ShaoHua Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/amazonq/test/unit/codewhisperer/util/runtimeLanguageContext.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,6 @@ describe('runtimeLanguageContext', function () {
]

for (const [inputCwsprLanguageId, expectedCwsprLanguageId] of codewhispererLanguageIds) {
if (inputCwsprLanguageId === 'systemVerilog') {
console.log()
}
Comment on lines -214 to -216
Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think it's dev purpose added in #5663

it(`should return ${expectedCwsprLanguageId} if input codewhispererLanguageId is - ${inputCwsprLanguageId}`, function () {
const actual = languageContext.toRuntimeLanguage(inputCwsprLanguageId)
assert.strictEqual(actual, expectedCwsprLanguageId)
Expand Down
6 changes: 6 additions & 0 deletions packages/core/src/codewhisperer/util/runtimeLanguageContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,17 @@ const runtimeLanguageSet: ReadonlySet<RuntimeLanguage> = new Set([
'kotlin',
'php',
'python',
'powershell',
Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified, equal to jb
const val ID = "powershell"

'r',
Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified, equal to jb
const val ID = "r"

'dart',
Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Oct 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified, equal to jb
const val ID = "dart"

'ruby',
'rust',
'scala',
'shell',
'sql',
'swift',
Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const val ID = "swift"

'lua',
Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Oct 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified, equal to jb
const val ID = "lua"

'vue',
Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Oct 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified, equal to jb
const val ID = "vue"

'typescript',
'json',
'yaml',
Expand Down
Loading