test(amazonq): performance test for LSP setup. #5677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hweinstock
changed the title
Contributor
Author
|
/runIntegrationTests |
jpinkney-aws
approved these changes
Oct 2, 2024
Contributor
jpinkney-aws
left a comment
jpinkney-aws
left a comment
There was a problem hiding this comment.
Since cpu/system are non deterministic we should document our performance testing strategy somewhere i.g. cpu/memory are purposely set higher to catch instances where cpu usage/memory/duration explodes on a code change and then use fs calls for determinism
justinmk3
reviewed
Oct 7, 2024
Contributor
There was a problem hiding this comment.
probably should start a subdir in testInteg, maybe testInteg/perf/ . Or perf tests could in "normal" places (testInteg/path/to/module/) but use a foo.perf.test.ts filename convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
continuation of reliability work
Solution
tryInstallLspinsrc/amazonq/lsp/lspController.tscaptures many potentially high risk paths in a single function, such as some I/O operations, and heavy use of theadmZipdependency.Two performance tests were added, one for handling zipping and maniupulating many small files, and one with few large files. Thresholds are set very leniently to avoid flaky tests.
The "many files" test does 250 files w/ 10 bytes each. The "large files" does 10 files w/ 1000 bytes each. These values were chosen to avoid flakiness in CI.
Included in this PR is removing the use of fs-extra in
src/amazonq/lsp/lspController.ts