test(amazonq): performance test for building index and sending to LSP. #5685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/runIntegrationTest |
jpinkney-aws
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
continuation of reliability work
Solution
buildIndexinsrc/amazonq/lsp/lspController.tscaptures many potentially high risk paths in a single function, such as some I/O operations and searching for project directories.Thresholds determined by running in CI a few times and multiplying the observed median by 1.5 to 2.0 depending on variance.
The "many files" test does 250 files w/ 10 bytes each. The "large files" does 10 files w/ 1000 bytes each. These values were chosen to avoid flakiness in CI.
Included in this PR is removing the use of fs-extra in
src/amazonq/lsp/lspController.tsLicense: I confirm that my contribution is made under the terms of the Apache 2.0 license.