telemetry(amazonq): change code percentage event to not consider modification for toolkit telemetry #5696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
leigaol
approved these changes
Oct 2, 2024
Contributor
leigaol
left a comment
leigaol
left a comment
There was a problem hiding this comment.
Better rename Pr to change code percentage event to not consider modification in toolkit telemetry reporting.
mention that the percentage code written in STE is not changed.
zixlin7
changed the title
hayemaxi
approved these changes
Oct 2, 2024
Contributor
|
Test failures are unrelated- tech debt only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Product thinks that code percentage event should not consider user modification
Solution
use raw accepted token count (without considering modification) for the percentage field in toolkit telemetry
there is no change to STE
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.