Skip to content

test(ec2): fix flaky tests regarding child node updates. #5698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2024
+13 −9
Merged

test(ec2): fix flaky tests regarding child node updates. #5698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42070bc
refactor to avoid async in for each
Hweinstock Sep 30, 2024
33400b4
stall tech debt timer
Hweinstock Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions packages/core/src/awsService/ec2/explorer/ec2ParentNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,19 @@ export class Ec2ParentNode extends AWSTreeNodeBase {
)
}

private updatePendingNodes() {
this.pollingSet.forEach(async (instanceId) => {
private async updatePendingNodes() {
for (const instanceId of this.pollingSet.values()) {
const childNode = this.ec2InstanceNodes.get(instanceId)!
await childNode.updateStatus()
if (!childNode.isPending()) {
this.pollingSet.delete(instanceId)
await childNode.refreshNode()
}
})
await this.updatePendingNode(childNode)
}
}

private async updatePendingNode(node: Ec2InstanceNode) {
await node.updateStatus()
if (!node.isPending()) {
this.pollingSet.delete(node.InstanceId)
await node.refreshNode()
}
}

public async clearChildren() {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/test/techdebt.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,6 @@ describe('tech debt', function () {
// Monitor telemtry to determine removal or snooze
// toolkit_showNotification.id = sessionSeparation
// auth_modifyConnection.action = deleteProfile OR auth_modifyConnection.source contains CodeCatalyst
fixByDate('2024-9-30', 'Remove the edge case code from the commit that this test is a part of.')
fixByDate('2024-10-30', 'Remove the edge case code from the commit that this test is a part of.')
})
})
Loading