Skip to content

Conversation

@Galaoaoa
Copy link
Contributor

@Galaoaoa Galaoaoa commented Oct 1, 2024

Problem

We will rename Application Composer to Infrastructure Composer as our service name. We need to do the same thing in VSCode toolkit

Solution

We will rename all user visible things first

@Galaoaoa Galaoaoa requested a review from a team as a code owner October 1, 2024 00:47
@github-actions
Copy link

github-actions bot commented Oct 1, 2024

This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@github-actions
Copy link

github-actions bot commented Oct 1, 2024

This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions.

Copy link
Contributor

@bildungsroman bildungsroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you rename the file locations, please name it something short like infraComposer/

@justinmk3 justinmk3 merged commit 7fdb8f9 into aws:master Oct 1, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants