telemetry(amazonq): Add client latency metrics for amazon q chat #5705
Conversation
|
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
| }) | ||
| } | ||
| /** | ||
| * We've received an answer for a tabID and this message has |
There was a problem hiding this comment.
Can you double check this callback? Is this code path executed when the first valid response is rendered to the customer chat panel or is it something else?
Specifically, does chat panel start rendering response when it receives item.type === ChatItemType.ANSWER_PART or item.type === ChatItemType.ANSWER
There was a problem hiding this comment.
Once this is merged, can you update relevant documentation? Thank you!
There was a problem hiding this comment.
The chat panel starts rending the response when it sees the answer part (lines 203-215). When we receive ChatItemType.ANSWER it means the message response is fully finished
|
Moved this back to draft so its not merged. They now want separate metrics for user latency and server latency |
Problem: - It's not clear what's meant by cwsprChatTimeToFirstChunk, cwsprChatTimeBetweenChunks, cwsprChatFullResponseLatency - We don't have any client latency metrics Solution: - Clarify the descriptions - Implement cwsprTimeToFirstDisplay, cwsprChatTimeBetweenDisplay, cwsprChatFullDisplayLatency metrics
jpinkney-aws
force-pushed
the
jpinkney-aws/fix-chunk
branch
from
10bfebe to
10e3ec8
Compare
jpinkney-aws
changed the title
4 participants
Problem:
Solution:
Other changes:
Risks:
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.