config(dev): re-enable Q dev API retry for read APIs #5706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
chengoramazon
force-pushed
the
chengora/retry
branch
from
408dd05 to
9649ad6
Compare
chengoramazon
changed the title
chengoramazon
force-pushed
the
chengora/retry
branch
from
9649ad6 to
323d154
Compare
chengoramazon
changed the title
willyyhuang
reviewed
Oct 2, 2024
willyyhuang
approved these changes
Oct 2, 2024
justinmk3
reviewed
Oct 2, 2024
|
|
||
| // Re-enable once BE is able to handle retries. | ||
| const writeAPIRetryOptions = { | ||
| maxRetries: 0, |
Contributor
There was a problem hiding this comment.
this is still at zero, so what effect does this PR have?
Contributor
Author
There was a problem hiding this comment.
It ensure Read APIs using default 3 retries. We don't handle write retries at this moment, but we would support it in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
/devconversation would got terminated by retry-able errors, since we disabled the default retry.Solution
/devfrom terminated by transient/retry-able errors.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.