Skip to content

Conversation

@Hweinstock
Copy link
Contributor

Problem

There is a test from recent PR that is incorrect given current structure. Ex. https://github.com/aws/aws-toolkit-vscode/actions/runs/11149044046/job/30987024464

Using globals.context.asAbsolutePath will prepend toolkit to the path, whereas we want to look in core for this file.

Solution

  • Manually construct the path to be checked.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented Oct 2, 2024

This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions.

@Hweinstock Hweinstock marked this pull request as ready for review October 2, 2024 20:44
@Hweinstock Hweinstock requested a review from a team as a code owner October 2, 2024 20:44
@justinmk3 justinmk3 enabled auto-merge (squash) October 2, 2024 22:03
@justinmk3 justinmk3 disabled auto-merge October 2, 2024 22:03
@justinmk3 justinmk3 merged commit 6e69c05 into aws:master Oct 2, 2024
8 of 10 checks passed
@Hweinstock Hweinstock deleted the fixIamTest branch October 3, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants