Skip to content

docs(amazonq): give context to why this function doesn't work as expected. #5721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 7, 2024
Merged

docs(amazonq): give context to why this function doesn't work as expected. #5721

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
278584d
add comment
Hweinstock Oct 3, 2024
9786132
update comment with PR link
Hweinstock Oct 3, 2024
4d2b2f0
change language
Hweinstock Oct 3, 2024
a3e8f37
Merge branch 'master' into blockCountContext
Hweinstock Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/core/src/codewhispererChat/controllers/chat/messenger/messenger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,22 @@ export class Messenger {
)
)
}

/**
* Tries to calculate the total number of code blocks.
* NOTES:
* - Not correct on all examples. Some may cause it to return 0 unexpectedly.
* - Plans in place (as of 4/22/2024) to move this server side.
* - See original pr: https://github.com/aws/aws-toolkit-vscode/pull/4761 for more details.
* @param message raw message response from codewhisperer client.
* @returns count of multi-line code blocks in response.
*/
public async countTotalNumberOfCodeBlocks(message: string): Promise<number> {
//TODO: remove this when moved to server-side.
if (message === undefined) {
return 0
}

// // To Convert Markdown text to HTML using marked library
// To Convert Markdown text to HTML using marked library
const html = await marked(message)

const dom = new JSDOM(html)
Expand Down
Loading