feat(cwl): Initialize TailLogGroup command with Wizard #5722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeganirby
changed the title
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
jpinkney-aws
reviewed
Oct 4, 2024
packages/core/src/awsService/cloudWatchLogs/commands/tailLogGroup.ts
Outdated
Show resolved
Hide resolved
packages/core/src/awsService/cloudWatchLogs/commands/tailLogGroup.ts
Outdated
Show resolved
Hide resolved
packages/core/src/awsService/cloudWatchLogs/liveTailLogStreamSubmenu.ts
Outdated
Show resolved
Hide resolved
packages/core/src/awsService/cloudWatchLogs/liveTailLogStreamSubmenu.ts
Outdated
Show resolved
Hide resolved
packages/core/src/awsService/cloudWatchLogs/liveTailLogStreamSubmenu.ts
Outdated
Show resolved
Hide resolved
packages/core/src/awsService/cloudWatchLogs/liveTailLogStreamSubmenu.ts
Outdated
Show resolved
Hide resolved
packages/core/src/test/awsService/cloudWatchLogs/commands/tailLogGroup.test.ts
Show resolved
Hide resolved
| }) | ||
| } | ||
|
|
||
| public validateLogStreamPrefix(prefix: string) { |
Contributor
There was a problem hiding this comment.
should this have a specific test or do you think its covered by the existing tests you wrote?
Contributor
Author
There was a problem hiding this comment.
It should be covered via the existing tests
jpinkney-aws
approved these changes
Oct 7, 2024
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
CWL is planning on supporting a LiveTail experience in AWSToolkit for VSCode Registers `aws.cwl.tailLogGroup` as a recognized command in AWS Toolkit. In this PR, running this command will simply take the user through a Wizard to collect the configuration for the tailing session, and logs it. In follow up PRs, I will take this Wizard input and use it to call CWL APIs and output streamed LogEvents to a TextDocument. This command will be able to be executed in the command pallet, or by pressing a "play button" icon when viewing LogGroups in the CloudWatch Logs explorer menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CWL is planning on supporting a LiveTail experience in AWSToolkit for VSCode
Solution
Registers
aws.cwl.tailLogGroupas a recognized command in AWS Toolkit.In this PR, running this command will simply take the user through a Wizard to collect the configuration for the tailing session, and logs it.
In follow up PRs, I will take this Wizard input and use it to call CWL APIs and output streamed LogEvents to a TextDocument.
This command will be able to be executed in the command pallet, or by pressing a "play button" icon when viewing LogGroups in the CloudWatch Logs explorer menu.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.