Skip to content

Conversation

@Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented Oct 4, 2024

Problem

we want to avoid contributors using fs-extra package, and prefer our fs wrapper.

Solution

Have ESLint do the job for us, error on attempting to import fs-extra.

Notes

  • the script files that already use fs-extra have been given exceptions since we don't need these to run in web.
  • A few fs-extra references existed, and were replaced.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented Oct 4, 2024

This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@github-actions
Copy link

github-actions bot commented Oct 4, 2024

This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions.

@Hweinstock Hweinstock marked this pull request as ready for review October 4, 2024 20:54
@Hweinstock Hweinstock requested a review from a team as a code owner October 4, 2024 20:54
@justinmk3 justinmk3 changed the title feat(lint): error on fs-extra import. ci(lint): error on fs-extra import. Oct 4, 2024
@justinmk3 justinmk3 changed the title ci(lint): error on fs-extra import. ci(lint): error on fs-extra import Oct 4, 2024
@justinmk3
Copy link
Contributor

the script files that already use fs-extra have been given exceptions since we don't need these to run in web.

If it's not much work to use node's 'fs' in those files, then that would allow us to remove the fs-extra dependency.

@justinmk3 justinmk3 merged commit 13282a0 into aws:master Oct 4, 2024
18 of 36 checks passed
@Hweinstock Hweinstock deleted the fsLintRule branch October 7, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants