-
Notifications
You must be signed in to change notification settings - Fork 737
ci(lint): error on fs-extra import #5730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
If it's not much work to use node's 'fs' in those files, then that would allow us to remove the fs-extra dependency. |
Problem
we want to avoid contributors using
fs-extrapackage, and prefer our fs wrapper.Solution
Have ESLint do the job for us, error on attempting to import
fs-extra.Notes
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.