feat(cwl): Create LiveTailSession object and registry. Adds MaxLine configuration #5738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeganirby
changed the title
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
jpinkney-aws
reviewed
Oct 8, 2024
packages/core/package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@amzn/codewhisperer-streaming": "file:../../src.gen/@amzn/codewhisperer-streaming", | ||
| "@aws-sdk/client-cloudwatch-logs": "^3.215.0", |
Contributor
There was a problem hiding this comment.
Are we able to update this to a slightly newer version? It looks like it created a bunch of churn in the package-lock.json since i'm guessing newer versions of the aws-sdk use different versions of smithy components, etc?
Contributor
Author
There was a problem hiding this comment.
Yes there is a newer version, will push with a revision!
packages/core/src/awsService/cloudWatchLogs/registry/liveTailSessionRegistry.ts
Outdated
Show resolved
Hide resolved
packages/core/src/test/awsService/cloudWatchLogs/registry/liveTailRegistry.test.ts
Outdated
Show resolved
Hide resolved
jpinkney-aws
approved these changes
Oct 15, 2024
justinmk3
reviewed
Oct 21, 2024
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
…onfiguration (aws#5738) 1. On the client side, VSCode needs to be aware of some additional context of a running LiveTail session, other than just the response from the StartLiveTail API call (Abort Controller, Max Lines config, TextDocument URI, etc). 2. Additionally, we want to be able to have multiple LiveTail sessions running, and have a way to organize all of them. 1. Create a LiveTailSession class in AWSToolkit that will persist all of the metadata and context the LiveTail feature needs to operate. 2. Create a LiveTailSessionRegistry that maps a vscode URI to a LiveTailSession. The URI for a LiveTailSession is composed of the API request elements. This will allow us to tell when a user is making a duplicate request. This URI will also be used as the URI of the TextDocument to display the session results. * Adds VSCode preference config for LiveTail max events. This will be used to cap the number of live tail events can be in the TextDocument at a given time. When the limit is reached, the oldest log events will be dropped in order to fit new events streaming in. * Adds a missing String for "Tail Log Group"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On the client side, VSCode needs to be aware of some additional context of a running LiveTail session, other than just the response from the StartLiveTail API call (Abort Controller, Max Lines config, TextDocument URI, etc).
Additionally, we want to be able to have multiple LiveTail sessions running, and have a way to organize all of them.
Solution
Additional Changes
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.