fix(dev): add error messages for upload URL expiry #5745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
jpinkney-aws
reviewed
Oct 8, 2024
chengoramazon
force-pushed
the
chengora/url-expire
branch
from
b304ac4 to
44978a4
Compare
chengoramazon
force-pushed
the
chengora/url-expire
branch
from
44978a4 to
f6c8c5c
Compare
| } | ||
|
|
||
| export class UploadURLExpired extends ToolkitError { | ||
| static errorName = 'UploadURLExpired' |
Contributor
There was a problem hiding this comment.
Does this make more sense to pass in to the name field, adjacent to the code?
Contributor
Author
There was a problem hiding this comment.
It is following existing pattern.
Contributor
There was a problem hiding this comment.
Those existing uses are incorrect, they are duplicating the existing name property. If you don't want to refactor that in this PR you can follow up and we can merge this now
nkomonen-amazon
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.