fix(dev): Allow user access history diff generated along iterations #5756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
SrcsGammaPDXCanaryUser
approved these changes
Oct 9, 2024
| new AppToWebViewMessageDispatcher(new MessagePublisher<any>(new vscode.EventEmitter<any>())) | ||
| ), | ||
| telemetry: new TelemetryHelper(), | ||
| uploadHistory: {}, |
There was a problem hiding this comment.
nit: Consider adding a test where uploadHistory is populated and show we can access an element from it
Contributor
There was a problem hiding this comment.
Sorry, used the wrong account here.
Contributor
Author
There was a problem hiding this comment.
Oh, I thought was somekind of automatic messaging. Thanks, yea, due the timeline I would say we can add those testing scenarios as a follow up PR
neilk-aws
approved these changes
Oct 9, 2024
| new AppToWebViewMessageDispatcher(new MessagePublisher<any>(new vscode.EventEmitter<any>())) | ||
| ), | ||
| telemetry: new TelemetryHelper(), | ||
| uploadHistory: {}, |
Contributor
There was a problem hiding this comment.
Sorry, used the wrong account here.
justinmk3
reviewed
Oct 9, 2024
packages/amazonq/.changes/next-release/Bug Fix-dd58d9cb-4fb4-4cb3-a9a2-dc5c5462e529.json
Outdated
Show resolved
Hide resolved
…cb3-a9a2-dc5c5462e529.json Co-authored-by: Justin M. Keyes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We currently only support accessing the last code generated (by the Tree view). If you try open the diff view in past history, will thrown an error. This happens because when we click on past history Tree we actually send a "newer" uploadId and didn't keep track of all the past ones.
Solution
Cache those uploadIds based on codeGenerationId which can be easily accessible while clicking in past views.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.