feat(stepfunctions): Implement bi-directional sync between local file and WFS #5773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
hayemaxi
reviewed
Oct 15, 2024
hayemaxi
reviewed
Oct 15, 2024
packages/core/src/stepFunctions/workflowStudio/handleMessage.ts
Outdated
Show resolved
Hide resolved
hayemaxi
reviewed
Oct 15, 2024
packages/core/src/stepFunctions/workflowStudio/handlers/saveFileMessageHandler.ts
Outdated
Show resolved
Hide resolved
justinmk3
reviewed
Oct 15, 2024
justinmk3
suggested changes
Oct 15, 2024
witness-me
force-pushed
the
wfs-basic-flow
branch
from
e8c488e to
17f27b5
Compare
Contributor
Author
|
New revision addresses the comments:
|
justinmk3
approved these changes
Oct 16, 2024
hayemaxi
approved these changes
Oct 17, 2024
hayemaxi
merged commit ba27519
into
aws:feature/stepfunctions-workflow
8 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Workflow Studio custom editor does not communicate bi-directly with local asl file
Solution
Adding bi-directional sync between local file and Workflow Studio custom editor
Additionally, adding send feedback functionality + handling webview loading indicator
Demo gif
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.