-
Notifications
You must be signed in to change notification settings - Fork 737
feat(ui): support multipick prompter #5815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
|
The code itself looks fine to me but I think we should really have tests for something like this before we merge it |
|
Thanks @jpinkney-aws I'm working on that, will ping you once added |
|
Hi @jpinkney-aws Please take another look when available. Thanks! |
|
/runintegrationtests |
justinmk3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing and the change is isolated, so we can iterate on this if needed. Meanwhile, it's great to have this in mainline. Thank you!
|
The failing integ tests are perf tests, unrelated to this PR. |
Problem
Currently prompter doesn't support multipick
Solution
Add a new function
createMultiPickthat supports multipick and can be used in Wizard.The returned result will be a list encoded by
JSON.stringify, useJSON.parseto recover the listProposed UX
TODO
Add Tests
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.