Skip to content

Conversation

@witness-me
Copy link
Contributor

@witness-me witness-me commented Oct 22, 2024

Problem

Workflow Studio (WFS) is opening for all asl files by default and there is no straightforward way to close it in favour of default editor if the user requires that. Additionally, there is no easy way open WFS from the current default editor

Solution

Adding options to close and reopen WFS custom editor:

  • WFS still launches as a default editor for asl files
  • On clicking the custom close button in WFS, the webview panel gets closed and the custom editor is opened instead
  • With the custom editor opened, there is an option to launch WFS by clicking codelens command on top of the file. This command will close current(default) editor and reopen the file in WFS. If WFS is already opened for the file, it will redirect to that tab
  • There is an additional option to launch WFS on right-click context menu on the file. For this case:
    • if there is a WFS for this file already launched, it will focus that tab
    • otherwise it will open file with WFS in the new tab
    • if the file is opened in the default editor, it will not be closed

Demo gif


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@witness-me witness-me requested a review from a team as a code owner October 22, 2024 22:43
@github-actions
Copy link

This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@github-actions
Copy link

This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions.

@hayemaxi
Copy link
Contributor

CI:

tech debt
       remove separate sessions login edge cases:

      AssertionError [ERR_ASSERTION]: Remove the edge case code from the commit that this test is a part of.

Not related to this PR and isn't a blocker, but consider merging from mainline so you don't see this anymore.

@hayemaxi
Copy link
Contributor

hayemaxi commented Oct 23, 2024

Looks like this is a UX change. Can you add a changelog item?

Nvm it's a feature branch.

@hayemaxi hayemaxi merged commit f48080f into aws:feature/stepfunctions-workflow Oct 23, 2024
8 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants