refactor(cw): avoid duplicating language list. #5859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
hayemaxi
reviewed
Oct 25, 2024
| if (languageId === undefined || defaultLanguages.includes(languageId)) { | ||
| return new Set<string>() | ||
| } | ||
| switch (languageId) { |
Contributor
There was a problem hiding this comment.
out of scope, but man this switch statement is brutal. Could probably cut the character count by more than half by using pass-through and not typing new Set<string> everywhere.
Contributor
Author
There was a problem hiding this comment.
Yeah I thought the same thing lol. These functions are basically just a giant map of languages to alternative names and policies.
hayemaxi
approved these changes
Oct 25, 2024
jpinkney-aws
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is the longest case of code duplication in the repo from
jscpd(46 lines!).Solution
Remove the duplication case, remove redundant if statement.
The switch statements could also be refactored into something with significantly less code in the future. Want to keep this PR focused on reducing code duplication.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.