Skip to content

Conversation

@Hweinstock
Copy link
Contributor

Problem

This is the second longest case of code duplication in the repo from jscpd (38 lines!).

Solution

Provide helper methods to build test objects.


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hweinstock Hweinstock marked this pull request as ready for review October 25, 2024 17:43
@Hweinstock Hweinstock requested a review from a team as a code owner October 25, 2024 17:43
@justinmk3
Copy link
Contributor

Please check this file on the https://github.com/aws/aws-toolkit-vscode-staging/tree/feature/lambda-get-started branch. If it still looks mostly the same there, then we can merge this. If it's removed there or heavily modified, we might want to skip this.

@justinmk3 justinmk3 merged commit 42f49a8 into aws:master Oct 25, 2024
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants