feat(sagemaker): free tier Q Chat with auto-login for iam users and login option for pro tier users #5886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
Contributor
Author
|
/runIntegrationTests. |
Contributor
|
/runIntegrationTests |
Contributor
|
This re-opens reverted PR: #5858 |
SM IAM permissions have been working as of v1.99 and now it's broken. This change brings it back to support code completion for SM code editor
justinmk3
reviewed
Oct 29, 2024
| # - "HTTPError: Response code …": caused by github rate-limiting. | ||
| # - "npm WARN deprecated querystring": transitive dep of aws sdk v2 (check `npm ls querystring`), so that's blocked until we migrate to v3. | ||
| _ignore_pat='Timed-out waiting for browser login flow\|HTTPError: Response code 403\|HTTPError: Response code 404\|npm WARN deprecated querystring' | ||
| _ignore_pat='Timed-out waiting for browser login flow\|HTTPError: Response code 403\|HTTPError: Response code 404\|npm WARN deprecated querystring\|npm WARN deprecated' |
Contributor
There was a problem hiding this comment.
This defeats the intention of one of our CI checks. In the future, please callout this kind of change in the PR description.
We'll accept this as a temporary workaround, but need to find something more granular.
hayemaxi
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AmazonQ
Solution
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.