Skip to content

feat(amazonq): upgrade Q LSP to 0.1.24 for UTG #5891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024
Merged

feat(amazonq): upgrade Q LSP to 0.1.24 for UTG #5891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions packages/core/src/amazonq/lsp/lspController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export interface Manifest {
}
const manifestUrl = 'https://aws-toolkit-language-servers.amazonaws.com/q-context/manifest.json'
// this LSP client in Q extension is only going to work with these LSP server versions
const supportedLspServerVersions = ['0.1.22', '0.1.19']
const supportedLspServerVersions = ['0.1.24']

const nodeBinName = process.platform === 'win32' ? 'node.exe' : 'node'

Expand Down Expand Up @@ -354,15 +354,14 @@ export class LspController {
credentialStartUrl: buildIndexConfig.startUrl,
})
} else {
// TODO: Re-enable this code path for LSP 0.1.20+
// getLogger().error(`LspController: Failed to build index of project`)
// telemetry.amazonq_indexWorkspace.emit({
// duration: performance.now() - start,
// result: 'Failed',
// amazonqIndexFileCount: 0,
// amazonqIndexFileSizeInMB: 0,
// reason: `Unknown`,
// })
getLogger().error(`LspController: Failed to build index of project`)
telemetry.amazonq_indexWorkspace.emit({
duration: performance.now() - start,
result: 'Failed',
amazonqIndexFileCount: 0,
amazonqIndexFileSizeInMB: 0,
reason: `Unknown`,
})
}
} catch (error) {
//TODO: use telemetry.run()
Expand Down
Loading