fix(lambda): skip ecrRepoUri and syncFlags prompters when using flag from samconfig file

[vicheey]

Problem

When customer choose use flag information from samconfig.toml for sync and deploy operations, we assume that all the needed parameters will be available in the samconfig.toml. Only --config-file <samconfig file path> is passed to SAM CLI.

We skip many prompters in such scenario reduce clicking. Yet, we also need to skip prompter for ecrRepoUri and syncFlag in sync wizard.

Solution

Add condition to skip these prompter when flag information from samconfig.toml is used.

---

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

[github-actions]

• This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
  • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
  • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

[roger-zhangg]

What would be syncFlags if we skipped here? Will it be empty?

[vicheey]

I believe that what we discussed last time.
When the customer use samconfig file, we use all the flag values from the file; this mean, we would use --config-file as mention here. The based on the value, the boundArgs is loaded here. We do not need the sync flags for merging with boundArgs here because again, --config-file is used.

Please let me know if there is issue.

[roger-zhangg]

What I mean is, are the sync flags actually empty if they are skipped. Could you help to confirm?

[vicheey]

Yes, confirm that it is an empty array

[roger-zhangg]

LGTM, thanks for improving the wizard experience

[roger-zhangg]

One thing we might want to checkout: if appbuilder failed to build/deploy/sync with the current param. Should we still allow use current param in the next try?

[hayemaxi]

/runIntegrationTests

[vicheey]

The integration tests failures do not seem to be related to the new change introduced in this PR but more like false negative resulted from issue with mocking.

[justinmk3]

The integration tests failures do not seem to be related to the new change introduced in this PR but more like false negative resulted from issue with mocking.

Do you plan to address that here or in a followup pr? It is unusual for integ tests to fail.

  1) SAM Integration Tests
       SAM Sync
         should instantiate ChildProcess with the correct arguments for sync: