-
Notifications
You must be signed in to change notification settings - Fork 737
fix(amazonq): default requestedConversions to undefined in manifest #5924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| } | ||
| | undefined | ||
| } | ||
| | undefined = undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the main change. Instead of defaulting to { sqlConversion: undefined }, which puts requestedConversions in the manifest.json, default to undefined, which leaves requestedConversions out of the manifest.json entirely.
| requestedConversions: | ||
| | { | ||
| sqlConversion: | ||
| | { | ||
| source: string | undefined | ||
| target: string | undefined | ||
| schema: string | undefined | ||
| host: string | undefined | ||
| sctFileName: string | undefined | ||
| } | ||
| | undefined | ||
| } | ||
| | undefined = undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would look nicer and also IMO be less confusing since we are removing so much text.
| requestedConversions: | |
| | { | |
| sqlConversion: | |
| | { | |
| source: string | undefined | |
| target: string | undefined | |
| schema: string | undefined | |
| host: string | undefined | |
| sctFileName: string | undefined | |
| } | |
| | undefined | |
| } | |
| | undefined = undefined | |
| requestedConversions?: { | |
| sqlConversion?: { | |
| source?: string | |
| target?: string | |
| schema?: string | |
| host?: string | |
| sctFileName?: string | |
| } | |
| } |
Problem
Recently noticed an issue where language upgrade transformations fail when our
manifest.jsonincludes this new key which was added for SQL conversions (unreleased feature).Solution
Use a default of
undefinedforrequestedConversions, so that it does not appear in themanifest.json, and only add it to themanifest.jsonwhen the user is doing a SQL conversion, as this key is only used for SQL conversions.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.