Skip to content

Conversation

@dhasani23
Copy link
Contributor

@dhasani23 dhasani23 commented Nov 4, 2024

Problem

Recently noticed an issue where language upgrade transformations fail when our manifest.json includes this new key which was added for SQL conversions (unreleased feature).

Solution

Use a default of undefined for requestedConversions, so that it does not appear in the manifest.json, and only add it to the manifest.json when the user is doing a SQL conversion, as this key is only used for SQL conversions.


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dhasani23 dhasani23 requested a review from a team as a code owner November 4, 2024 22:55
@github-actions
Copy link

github-actions bot commented Nov 4, 2024

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

}
| undefined
}
| undefined = undefined
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main change. Instead of defaulting to { sqlConversion: undefined }, which puts requestedConversions in the manifest.json, default to undefined, which leaves requestedConversions out of the manifest.json entirely.

Comment on lines 333 to 345
requestedConversions:
| {
sqlConversion:
| {
source: string | undefined
target: string | undefined
schema: string | undefined
host: string | undefined
sctFileName: string | undefined
}
| undefined
}
| undefined = undefined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would look nicer and also IMO be less confusing since we are removing so much text.

Suggested change
requestedConversions:
| {
sqlConversion:
| {
source: string | undefined
target: string | undefined
schema: string | undefined
host: string | undefined
sctFileName: string | undefined
}
| undefined
}
| undefined = undefined
requestedConversions?: {
sqlConversion?: {
source?: string
target?: string
schema?: string
host?: string
sctFileName?: string
}
}

@dhasani23 dhasani23 merged commit 9f63bbf into aws:master Nov 5, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants