Skip to content

Conversation

@kelvin-klchu
Copy link
Contributor

Problem

For the current /dev experience for code review, user needs to review the entire file list of generated code, reject the changes they do not want, and then accept the remaining changes in bulk at the end.

This PR introduces improvements in user experience around the code review experience in which user can now review the file changes and accept them one at a time. User can start editing the file right away after accepting the changes without having to go through the entire generated file list.

Solution

new-action-button file-accepted
  • introduces a new action button for accepting file change for each change suggested on the file list
  • accepted changes are now highlighted in green
  • when accepting changes in bulk, the file list is updated to reflect the status if a change is rejected or accepted
  • minor text changes / improvements

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kelvin-klchu kelvin-klchu requested review from a team as code owners November 5, 2024 17:34
@github-actions
Copy link

github-actions bot commented Nov 5, 2024

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@kelvin-klchu kelvin-klchu marked this pull request as draft November 6, 2024 15:36
@kelvin-klchu kelvin-klchu force-pushed the feat/file-level-acceptance branch from 5ece3e8 to 01ee985 Compare November 7, 2024 20:25
@kelvin-klchu kelvin-klchu force-pushed the feat/file-level-acceptance branch from a303860 to ace7b9a Compare November 8, 2024 16:32
@Hweinstock
Copy link
Contributor

/runIntegrationTests

@kelvin-klchu kelvin-klchu marked this pull request as ready for review November 8, 2024 23:19
@nkomonen-amazon
Copy link
Contributor

@kelvin-klchu could you add a changelog item

@kelvin-klchu kelvin-klchu force-pushed the feat/file-level-acceptance branch from 90ecff7 to e16ce6e Compare November 12, 2024 21:06
@kelvin-klchu
Copy link
Contributor Author

rebased and added changelog

@justinmk3 justinmk3 merged commit c09b09a into aws:master Nov 12, 2024
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants