-
Notifications
You must be signed in to change notification settings - Fork 732
feat(dev): File-level accepts of generated code #5928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
justinmk3
merged 33 commits into
aws:master
from
kelvin-klchu:feat/file-level-acceptance
Nov 12, 2024
Merged
feat(dev): File-level accepts of generated code #5928
justinmk3
merged 33 commits into
aws:master
from
kelvin-klchu:feat/file-level-acceptance
Nov 12, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tverney
reviewed
Nov 5, 2024
tverney
approved these changes
Nov 5, 2024
packages/core/src/amazonqFeatureDev/controllers/chat/controller.ts
Outdated
Show resolved
Hide resolved
justinmk3
reviewed
Nov 5, 2024
packages/core/src/test/amazonqFeatureDev/controllers/chat/controller.test.ts
Outdated
Show resolved
Hide resolved
justinmk3
reviewed
Nov 5, 2024
packages/core/src/test/amazonqFeatureDev/controllers/chat/controller.test.ts
Outdated
Show resolved
Hide resolved
5ece3e8 to
01ee985
Compare
tverney
reviewed
Nov 7, 2024
tverney
approved these changes
Nov 7, 2024
a303860 to
ace7b9a
Compare
Contributor
|
/runIntegrationTests |
Contributor
|
@kelvin-klchu could you add a changelog item |
90ecff7 to
e16ce6e
Compare
Contributor
Author
|
rebased and added changelog |
justinmk3
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For the current /dev experience for code review, user needs to review the entire file list of generated code, reject the changes they do not want, and then accept the remaining changes in bulk at the end.
This PR introduces improvements in user experience around the code review experience in which user can now review the file changes and accept them one at a time. User can start editing the file right away after accepting the changes without having to go through the entire generated file list.
Solution
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.