Skip to content

fix(appbuilder): getSpawnEnv should return correct env on windows #5936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 7, 2024
Merged

fix(appbuilder): getSpawnEnv should return correct env on windows #5936

merged 13 commits into from
Nov 7, 2024

Conversation

@roger-zhangg
Copy link
Member

@roger-zhangg roger-zhangg commented Nov 6, 2024 •
edited by justinmk3
Loading

Problem

See: #5933 #5918

Solution

Added a check in resolveEnv to make sure it should do nothing on windows.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@roger-zhangg roger-zhangg requested a review from a team as a code owner November 6, 2024 18:06
@github-actions
Copy link

github-actions bot commented Nov 6, 2024

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@roger-zhangg
Copy link
Member Author

roger-zhangg commented Nov 6, 2024 •
edited
Loading

Windows: build process in local invoke can find Nodejs/Dotnet CLI correctly after this fix.

@seshubaws
Copy link
Contributor

seshubaws commented Nov 6, 2024

Can you add a changelog for this?

seshubaws
seshubaws suggested changes Nov 6, 2024
View reviewed changes
jonife
jonife reviewed Nov 6, 2024
View reviewed changes
justinmk3
justinmk3 reviewed Nov 6, 2024
View reviewed changes
justinmk3
justinmk3 reviewed Nov 6, 2024
View reviewed changes
justinmk3
justinmk3 reviewed Nov 6, 2024
View reviewed changes
justinmk3
justinmk3 reviewed Nov 6, 2024
View reviewed changes
justinmk3
justinmk3 reviewed Nov 6, 2024
View reviewed changes
@justinmk3 justinmk3 merged commit 19d0062 into aws:master Nov 7, 2024
9 of 17 checks passed
@Hweinstock Hweinstock mentioned this pull request Nov 7, 2024
Merged
justinmk3 pushed a commit that referenced this pull request Nov 8, 2024
@Hweinstock
fix(ec2): timeout ssh tryKeyGen to avoid hanging #5951
8113288 
## Problem
Starting in #5936 some
tests started expiring, since fixed in
#5954. However, than
expire, the `SshKeyPair` tests hang because they are stuck in a child
process. This leads to these tests failing to timeout, even when
exceeding the test timeout threshold.

## Solution
Add explicit timeout on the child process we use to spawn ssh keys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@justinmk3 justinmk3 justinmk3 left review comments

@Vandita2020 Vandita2020 Vandita2020 left review comments

@jonife jonife jonife left review comments

@seshubaws seshubaws seshubaws approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@roger-zhangg @seshubaws @justinmk3 @Vandita2020 @jonife