ci(jscpd): check changed lines instead of changed files to avoid false positives #5950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hweinstock
force-pushed
the
jscpd/changedlines
branch
from
ae4e548 to
451a58f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Hweinstock
changed the title
Hweinstock
changed the title
justinmk3
reviewed
Dec 23, 2024
justinmk3
reviewed
Dec 23, 2024
justinmk3
approved these changes
Dec 23, 2024
justinmk3
changed the title
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
## Problem The `jscpd` check checks changed *files*. So duplicate code may be reported on lines outside of the actual changes (in the same file), which may be considered false positives. ## Solution - Only report "clones" (duplicate code) on actually changed lines. - Refactor the action to simplify the bash scripting. - Add tests for `filterDuplicates.ts`.
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem The `jscpd` check checks changed *files*. So duplicate code may be reported on lines outside of the actual changes (in the same file), which may be considered false positives. ## Solution - Only report "clones" (duplicate code) on actually changed lines. - Refactor the action to simplify the bash scripting. - Add tests for `filterDuplicates.ts`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently
jscpdci action filters on changed files in PR. This results in clones being returned from changes outside our changes (but within the same files).jscpdis the most commonly failing CI task at the moment, so to keep CI green we want to reduce false positives.Solution
jscpdonly lists clones that includes lines from the changed lines in the changed files.filterDuplicates.tsscript to make future changes easier.See 12fc4d6 for an example failure.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.