Skip to content

Conversation

@leigaol
Copy link
Contributor

@leigaol leigaol commented Nov 7, 2024

Problem

Solution


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested a review from a team as a code owner November 7, 2024 20:34
@github-actions
Copy link

github-actions bot commented Nov 7, 2024

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@justinmk3
Copy link
Contributor

ci is failing

Comment on lines +28 to +39
{
"shape": "ThrottlingException"
},
{
"shape": "InternalServerException"
},
{
"shape": "ValidationException"
},
{
"shape": "AccessDeniedException"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use the file with the same formatting?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff is too large and most of them are formatting changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hardly can tell which changes are the purpose of this pr

@Will-ShaoHua
Copy link
Contributor

Will-ShaoHua commented Nov 8, 2024

#5695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants