Skip to content

Conversation

@nkomonen-amazon
Copy link
Contributor

Problem

When opening the AWS Developer Menu for toolkit, no items were showing.

This is due to a wrong value being used for menu options. The second use was expecting it to be an object with keys, when it was actually a function. This happened due to a recent change that didn't catch this


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

The second use was expecting it to be an object with keys, when it was
actually a function.

This happened due to a recent change that didn't catch this

Signed-off-by: nkomonen-amazon <[email protected]>
@nkomonen-amazon nkomonen-amazon requested a review from a team as a code owner November 11, 2024 18:15
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@justinmk3 justinmk3 merged commit 43299f3 into aws:master Nov 11, 2024
12 of 17 checks passed
@nkomonen-amazon nkomonen-amazon deleted the fixDevMenu branch November 11, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants