Skip to content

refactor(logger): deeply nested objects fail to show up in logs. #5984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 13, 2024
+55 −7
Merged

refactor(logger): deeply nested objects fail to show up in logs. #5984

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
09a3b36
switch back to JSON.stringify as exception
Hweinstock Nov 12, 2024
5c2cab2
cap depth at 12
Hweinstock Nov 12, 2024
e091dc3
Merge branch 'master' into loggingNestedObj
Hweinstock Nov 12, 2024
02dde97
Merge branch 'master' into loggingNestedObj
Hweinstock Nov 12, 2024
8962008
implement general inspect method
Hweinstock Nov 13, 2024
d436022
rename to formatObj
Hweinstock Nov 13, 2024
0f15eb1
refactor some details
Hweinstock Nov 13, 2024
12a09a2
update test cases
Hweinstock Nov 13, 2024
5628434
address lint failure
Hweinstock Nov 13, 2024
8c27467
pass in inspect options only
Hweinstock Nov 13, 2024
67e9d9f
Merge branch 'master' into loggingNestedObj
Hweinstock Nov 13, 2024
797293f
undo formatting change
Hweinstock Nov 13, 2024
11f293e
Update packages/core/src/shared/utilities/collectionUtils.ts
Hweinstock Nov 13, 2024
5ad9c7e
remove InspectOptions
Hweinstock Nov 13, 2024
5a7014c
modify lint message
Hweinstock Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/core/src/codewhispererChat/controllers/chat/controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,10 @@ export class ChatController {

const request = triggerPayloadToChatRequest(triggerPayload)
const session = this.sessionStorage.getSession(tabID)
getLogger().info(`request from tab: ${tabID} conversationID: ${session.sessionIdentifier} request: %O`, request)
//eslint-disable-next-line aws-toolkits/no-json-stringify-in-log
getLogger().info(
`request from tab: ${tabID} conversationID: ${session.sessionIdentifier} request: ${JSON.stringify(request)}`
)
let response: MessengerResponseType | undefined = undefined
session.createNewTokenSource()
try {
Expand All @@ -672,11 +675,11 @@ export class ChatController {
this.telemetryHelper.recordEnterFocusConversation(triggerEvent.tabID)
this.telemetryHelper.recordStartConversation(triggerEvent, triggerPayload)

//eslint-disable-next-line aws-toolkits/no-json-stringify-in-log
getLogger().info(
`response to tab: ${tabID} conversationID: ${session.sessionIdentifier} requestID: ${
response.$metadata.requestId
} metadata: %O`,
response.$metadata
} metadata: ${JSON.stringify(response.$metadata)}`
)
await this.messenger.sendAIResponse(response, session, tabID, triggerID, triggerPayload)
} catch (e: any) {
Expand Down
Loading