test(appbuilder): optimize and fix flaky test in appbuilder #6003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
Nov 13, 2024
| const workspaceUri = vscode.workspace.workspaceFolders?.[0]?.uri | ||
| assert.ok(workspaceUri) | ||
| await fs.writeFile(vscode.Uri.joinPath(workspaceUri, 'template.yaml'), 'random text') | ||
| const prevInfo = await fs.readFileText(vscode.Uri.joinPath(workspaceUri, 'template.yaml')) |
Contributor
There was a problem hiding this comment.
Just for future reference: can also use waitUntil to retry.
justinmk3
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fix #6000
Fix flaky test here
https://github.com/aws/aws-toolkit-vscode/actions/runs/11822049864/job/32938204047?pr=5988
Solution
The flaky issue happens when the file failed to be created before test run
move file preparation step into
beforeEachso it will be more reliable.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.