fix(cwl): Set LogEventFilter when constructing LiveTailSession #6008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
packages/core/src/test/awsService/cloudWatchLogs/registry/liveTailSession.test.ts
Outdated
Show resolved
Hide resolved
justinmk3
reviewed
Nov 13, 2024
packages/core/src/test/awsService/cloudWatchLogs/registry/liveTailSession.test.ts
Show resolved
Hide resolved
justinmk3
reviewed
Nov 13, 2024
packages/core/src/test/awsService/cloudWatchLogs/registry/liveTailSession.test.ts
Outdated
Show resolved
Hide resolved
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
## Problem LogEventFilter is an optional configuration parameter when building a LiveTailSession. Currently, the Constructor is not actually setting this property so it is always undefined. This means that if a user sets a Filter pattern, it will not be applied. ## Solution Set the property in LiveTailSession Constructor. Add missing unit tests to validate that LiveTailSession config values are set properly. Testing via `buildStartLiveTailCommand` because this is what actually gets sent to the CWL backend to start a LiveTailSession.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
LogEventFilter is an optional configuration parameter when building a LiveTailSession. Currently, the Constructor is not actually setting this property so it is always undefined. This means that if a user sets a Filter pattern, it will not be applied.
Solution
Set the property in LiveTailSession Constructor.
Add missing unit tests to validate that LiveTailSession config values are set properly. Testing via
buildStartLiveTailCommandbecause this is what actually gets sent to the CWL backend to start a LiveTailSession.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.