fix(logger): support module-scope getLogger() #6026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Assigning a `const logger = getLogger()` in module scope, may default to `ConsoleLogger`, because modules may be loaded before logging is initialized. Solution: Move the decision into `TopicLogger`, so that the time of the `getLogger()` assignment is irrelevant (just-in-time).
This comment was marked as resolved.
This comment was marked as resolved.
nkomonen-amazon
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Assigning a
const logger = getLogger()in module scope, may default toConsoleLogger, because modules may be loaded before logging is initialized.Solution
Move the decision into
TopicLogger, so that the time of thegetLogger()assignment is irrelevant (just-in-time).License: I confirm that my contribution is made under the terms of the Apache 2.0 license.