-
Notifications
You must be signed in to change notification settings - Fork 735
deps(sdkv3): add tests for refreshing credentials on client. #6051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Hweinstock
wants to merge
24
commits into
aws:feature/sdkv3
from
Hweinstock:sdkv3/credentialsTesting
Closed
deps(sdkv3): add tests for refreshing credentials on client. #6051
Hweinstock
wants to merge
24
commits into
aws:feature/sdkv3
from
Hweinstock:sdkv3/credentialsTesting
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
built on changes in https://github.com/aws/aws-toolkit-vscode/pull/5940/files
Problem
The client should not be making requests with stale credentials so we want test coverage to ensure this.
Solution
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.