Skip to content

Conversation

@Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented Nov 19, 2024

built on changes in https://github.com/aws/aws-toolkit-vscode/pull/5940/files

Problem

The client should not be making requests with stale credentials so we want test coverage to ensure this.

Solution

  • Create a mock credentials shim and insert it into the global context.
  • The client builder will then use that shim, and we can manually expire it.
  • Ensure client does not cache potentially stale credentials.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hweinstock Hweinstock changed the base branch from master to feature/sdkv3 November 20, 2024 18:49
@Hweinstock Hweinstock changed the title deps(sdkv3): add test for refreshing credentials on client. deps(sdkv3): add tests for refreshing credentials on client. Nov 20, 2024
@Hweinstock Hweinstock deleted the branch aws:feature/sdkv3 November 22, 2024 20:24
@Hweinstock Hweinstock closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant