Skip to content

test(amazonq): skip flaky crossfileContextUtil.test #6085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2024
Merged

test(amazonq): skip flaky crossfileContextUtil.test #6085

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4ad374
skip flaky crossfileContextUtil.test
Will-ShaoHua Nov 21, 2024
1e2a29e
patch
Will-ShaoHua Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/amazonq/test/unit/codewhisperer/util/crossFileContextUtil.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ describe('crossFileContextUtil', function () {
sinon.restore()
})

describe('fetchSupplementalContextForSrc', function () {
describe.skip('fetchSupplementalContextForSrc', function () {
Copy link
Contributor

@Hweinstock Hweinstock Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only seen the for t1 group, should return repomap + opentabs context one fail. Is there a reason we want to skip the other two in this block?

Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

um, i just think the t1 test are pretty much the same as t2 test, so it's still unclear to me why one fails but the other doesn't.
However let's skip t1 test only for now and skip others when we observe other failure, also it could help me narrow down where it likely went wrong.

beforeEach(async function () {
tempFolder = (await createTestWorkspaceFolder()).uri.fsPath
})
Expand Down
Loading