Skip to content

Conversation

@Will-ShaoHua
Copy link
Contributor

Problem

enable implicit workspace ab test for broader groups of users but not only internal users

Solution

remove isInternalUser predicate


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review November 25, 2024 21:24
@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner November 25, 2024 21:24
@Will-ShaoHua Will-ShaoHua marked this pull request as draft November 25, 2024 21:38
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review November 26, 2024 02:32
Comment on lines 636 to 637
// if user does not have @workspace in the prompt, but user is Amazon internal
// add project context by default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// if user does not have @workspace in the prompt, but user is Amazon internal
// add project context by default

@jpinkney-aws jpinkney-aws merged commit 61d67f8 into aws:master Nov 26, 2024
24 of 25 checks passed
justinmk3 pushed a commit that referenced this pull request Jan 27, 2025
…ment group #6217

## Problem
Most users might have disabled workspace context due to previous
sub-process performance issue, therefore #6098 experiment has too few
datapoints.

## Solution
As we've been actively working on fixes to improve the amazon q helper
sub-process performance, the team decided to try turn on (only once)
workspace context for a small fraction of all users (20%) to collect few
more datapoints.
s7ab059789 pushed a commit to s7ab059789/aws-toolkit-vscode that referenced this pull request Feb 19, 2025
…ment group aws#6217

## Problem
Most users might have disabled workspace context due to previous
sub-process performance issue, therefore aws#6098 experiment has too few
datapoints.

## Solution
As we've been actively working on fixes to improve the amazon q helper
sub-process performance, the team decided to try turn on (only once)
workspace context for a small fraction of all users (20%) to collect few
more datapoints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants