test: add notification and reset state dev options #6105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayemaxi
force-pushed
the
notifications8
branch
from
144e77b to
bbfdd19
Compare
- Add a generic dev menu item to reset the state of a feature. Simply extend with a function handler to add an item to the menu. The initial item resets in-ide notification state. - Add a way to test notifications locally without modifying code. Using a dev menu item you can add a notification to global state and receive it in your IDE for visualization. - Refactor notifications controller to not require a RuleEngine when polling is requested.
hayemaxi
force-pushed
the
notifications8
branch
from
bbfdd19 to
21e956c
Compare
Contributor
Author
|
/runIntegrationTests |
nkomonen-amazon
approved these changes
Nov 26, 2024
| DevSettings.instance.isDevMode() ? new DevFetcher() : new RemoteFetcher() | ||
| ) | ||
|
|
||
| await controller.pollForStartUp() |
Contributor
There was a problem hiding this comment.
Are these making a network call? If so I wonder if we should not block to improve startup performance
Contributor
Author
There was a problem hiding this comment.
Yes excellent catch, this was a bug fixed by #6052
Contributor
|
Thanks for adding in the reset state feature, will be useful for a lot of things |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a generic dev menu item to reset the state of a feature. Simply extend with a function handler to add an item to the menu. The initial item resets in-ide notification state.
Add a way to test notifications locally without modifying code. Using a dev menu item you can add a notification to global state and receive it in your IDE for visualization.
Refactor notifications controller to not require a RuleEngine when polling is requested.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.