fix(amazonq): /dev to support upload of nested dockerfiles #6115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
avi-alpert
approved these changes
Nov 27, 2024
neilk-aws
approved these changes
Nov 27, 2024
michaellandi
changed the title
justinmk3
reviewed
Nov 27, 2024
justinmk3
reviewed
Nov 27, 2024
michaellandi
changed the title
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
Nested `Dockerfile` files were not supported with aws#6107 Look at path basename when comparing file to list of well known files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[POST RE:INVENT]
Problem
Nested
Dockerfilefiles were not supported with #6107Solution
Look at path basename when comparing file to list of well known files.
I manually tested adding nested
Dockerfiles to various folders and ensured that pattern matched.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.