Skip to content

Conversation

@laileni-aws
Copy link
Contributor

@laileni-aws laileni-aws commented Dec 3, 2024

Problem

  • UTG toolkit telemetry can not differentiate the users from builderID users vs internal IAM IDC users vs external enterprise users.

Solution

  • Adding credentialUrl = AuthUtil.instance.startUrl field to differentiate the builderID users vs internal IAM IDC users vs external enterprise users.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laileni-aws laileni-aws requested a review from a team as a code owner December 3, 2024 21:29
@github-actions
Copy link

github-actions bot commented Dec 3, 2024

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@justinmk3
Copy link
Contributor

@justinmk3 justinmk3 changed the title telemetry(amazonq): Adding credentialUrl to differentiate the Internal Users vs External users telemetry(amazonq): differentiate Internal vs External users Dec 3, 2024
@laileni-aws laileni-aws enabled auto-merge (squash) December 3, 2024 22:02
@laileni-aws laileni-aws merged commit 2b49a5d into aws:master Dec 3, 2024
24 of 36 checks passed
avi-alpert pushed a commit to avi-alpert/aws-toolkit-vscode that referenced this pull request Dec 4, 2024
## Problem
- UTG toolkit telemetry can not differentiate the users from builderID
users vs internal IAM IDC users vs external enterprise users.

## Solution
- Adding `credentialUrl = AuthUtil.instance.startUrl` field to
differentiate the builderID users vs internal IAM IDC users vs external
enterprise users.

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).

License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants