Skip to content

refactor(ec2): avoid logging somewhat sensitive data #6149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2024
Merged

refactor(ec2): avoid logging somewhat sensitive data #6149

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d033ec7
avoid logging token
Hweinstock Dec 4, 2024
42c14ac
use require no log instead
Hweinstock Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/core/resources/ec2_connect
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ _require_nolog() {

_require() {
_require_nolog "$@"
_log "$1=$2"
}

_ec2() {
Expand All @@ -52,6 +51,12 @@ _main() {
_require SESSION_ID "${SESSION_ID:-}"
_require LOG_FILE_LOCATION "${LOG_FILE_LOCATION:-}"

# Avoid logging sensitive data
_log "AWS_SSM_CLI=$AWS_SSM_CLI"
_log "AWS_REGION=$AWS_REGION"
_log SESSION_ID "${SESSION_ID:-}"
_log "LOG_FILE_LOCATION=$LOG_FILE_LOCATION"

_ec2 "$AWS_SSM_CLI" "$AWS_REGION" "$STREAM_URL" "$TOKEN" "$SESSION_ID"
}

Expand Down
1 change: 1 addition & 0 deletions packages/core/src/awsService/ec2/model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ export class Ec2Connecter implements vscode.Disposable {
await this.addActiveSession(selection.instanceId, ssmSession.SessionId!)

const vars = getEc2SsmEnv(selection, ssm, ssmSession)
getLogger().info(`ec2: connect script logs at ${vars.LOG_FILE_LOCATION}`)
const envProvider = async () => {
return { [sshAgentSocketVariable]: await startSshAgent(), ...vars }
}
Expand Down
Loading