Skip to content

Conversation

@jpinkney-aws
Copy link
Contributor

Problem

  • vscode doesn't have the codewhisperer lsp for completion requests

Solution

  • use the codewhisperer lsp when "aws.experiments": { "amazonqLSP": true },

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpinkney-aws jpinkney-aws requested review from a team as code owners December 5, 2024 16:14
@github-actions
Copy link

github-actions bot commented Dec 5, 2024

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

LspClient.instance.client = new LanguageClient(
'amazonq',
localize('amazonq.server.name', 'Amazon Q Language Server'),
localize('amazonq.server.name', 'Amazon Q Workspace Language Server'),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed this to the workspace server for now. I think at some point it makes sense to consolidate it into the actual language servers?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, in https://taskei.amazon.dev/tasks/IDE-15333 we actually propose to interleave LSP messages with the Amazon Q Logs channel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Will hook that up once the postreinvent branch gets merged into master

"serveVue": "Local server for Vue.js code for development purposes. Provides faster iteration when updating Vue files"
},
"devDependencies": {
"@aws/language-server-runtimes": "0.2.27",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this live in packages/amazonq/package.json ? I guess not, because toolkit may want to use aws lsp too. Plus it's a "dev" dep so less of a concern.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will want this for the notifications language server (I believe that's still happening?)

@jpinkney-aws jpinkney-aws merged commit 5d6512f into aws:feature/amazonqLSP Dec 5, 2024
17 checks passed
@jpinkney-aws jpinkney-aws deleted the language-server-loading branch December 5, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants