-
Notifications
You must be signed in to change notification settings - Fork 744
feat(amazonq): Use codewhisperer language server for completions #6158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(amazonq): Use codewhisperer language server for completions #6158
Conversation
|
| LspClient.instance.client = new LanguageClient( | ||
| 'amazonq', | ||
| localize('amazonq.server.name', 'Amazon Q Language Server'), | ||
| localize('amazonq.server.name', 'Amazon Q Workspace Language Server'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed this to the workspace server for now. I think at some point it makes sense to consolidate it into the actual language servers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, in https://taskei.amazon.dev/tasks/IDE-15333 we actually propose to interleave LSP messages with the Amazon Q Logs channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Will hook that up once the postreinvent branch gets merged into master
packages/core/package.json
Outdated
| "serveVue": "Local server for Vue.js code for development purposes. Provides faster iteration when updating Vue files" | ||
| }, | ||
| "devDependencies": { | ||
| "@aws/language-server-runtimes": "0.2.27", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this live in packages/amazonq/package.json ? I guess not, because toolkit may want to use aws lsp too. Plus it's a "dev" dep so less of a concern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will want this for the notifications language server (I believe that's still happening?)
Problem
Solution
"aws.experiments": { "amazonqLSP": true },feature/xbranches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.